Skip to content

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Jul 30, 2022

About

This pull request synchronises the unstable branch to stable branch for v4.3.0's release.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue (If existent):.
    • resolves #
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

Damego and others added 8 commits July 25, 2022 07:11
* refactor: change condition for getting error message

* ci: correct from checks.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* return back fix

* return back Delta fix

* make check like Delta

* Update attrs_utils.py
* refactor: separate Emoji to own module

* fix imports

* rename imports in http

* change brackets

* ci: pre-commit

* fix: fix incorrect role converts in Emoji

* ref: remove Role import
* fix: fix error ``Attachment`` is not JSON serializable

* Update interactions/api/models/message.py

Co-authored-by: EdVraz <[email protected]>
* refactor!: Add converters to components

* ci: run pre-commit

* doc: add missed docstring

* oop
@FayeDel FayeDel added the priority This Issue/PR must be resolved first before accepting any others label Jul 30, 2022
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed - looks good for merging and publishing to me

@FayeDel FayeDel merged commit 53407b1 into stable Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority This Issue/PR must be resolved first before accepting any others

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants