Skip to content

Conversation

@Damego
Copy link
Member

@Damego Damego commented Jul 24, 2022

About

This pull request fixes these bugs:

  • An error occured dispatching channel_update: 'NoneType' object has no attribute 'id'
  • on_message_update(before, after) before always is None When you edit a message which not in cache
  • Wrong getting id of models

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@Damego
Copy link
Member Author

Damego commented Jul 24, 2022

Draft until I test everything

@FayeDel FayeDel added the bug Something isn't working label Jul 24, 2022
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, LGTM!

@Damego
Copy link
Member Author

Damego commented Jul 24, 2022

I will test it more tommorow. I wanna sleep

@Damego
Copy link
Member Author

Damego commented Jul 24, 2022

I didn't get any error so we can merge it ig

@Damego Damego marked this pull request as ready for review July 24, 2022 18:59
@Damego Damego requested a review from EepyElvyra July 24, 2022 18:59
@EepyElvyra EepyElvyra merged commit 5bdf254 into interactions-py:unstable Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants