Skip to content

feat!: smarter option decorator #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Toricane merged 2 commits into from
Jul 22, 2022
Merged

feat!: smarter option decorator #950

Toricane merged 2 commits into from
Jul 22, 2022

Conversation

@Toricane
Copy link
Contributor

@Toricane Toricane commented Jul 21, 2022

About

This pull request implements a smarter option decorator.
This is breaking when compared to earlier versions of unstable and beta.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@Toricane Toricane added documentation Improvements or additions to documentation enhancement New feature or request breaking This contains breaking changes labels Jul 21, 2022
@Toricane
feat!: optimize option decorator
a961543 
BREAKING: breaks previous implementation
@Toricane Toricane enabled auto-merge (squash) July 22, 2022 00:08
@Toricane Toricane self-assigned this Jul 22, 2022
@Toricane Toricane merged commit 89e349f into interactions-py:unstable Jul 22, 2022
@Toricane Toricane deleted the feat-smarter-option-decorator branch July 23, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

@FayeDel FayeDel Awaiting requested review from FayeDel

1 more reviewer

@EepyElvyra EepyElvyra EepyElvyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Toricane Toricane

Labels

breaking This contains breaking changes documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Toricane @EepyElvyra