Skip to content

feat: Remove PresenceButton object. #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EepyElvyra merged 1 commit into from
Jul 16, 2022
Merged

feat: Remove PresenceButton object. #935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions interactions/api/models/presence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"PresenceTimestamp",
"PresenceActivity",
"PresenceActivityType",
"PresenceButtons",
"ClientPresence",
)

Expand Down Expand Up @@ -64,19 +63,6 @@ class PresenceSecrets(DictSerializerMixin):
match: Optional[str] = field(default=None)


@define()
class PresenceButtons(DictSerializerMixin):
"""
A class object representing the buttons of a presence.

:ivar str label: Text of the button
:ivar str url: URL of the button
"""

label: str = field()
url: str = field()


@define()
class PresenceTimestamp(DictSerializerMixin):
"""
Expand Down Expand Up @@ -109,8 +95,11 @@ class PresenceActivity(DictSerializerMixin):
A class object representing the current activity data of a presence.

.. note::
When using this model to instantiate alongside the client, if you provide a type 1 ( or PresenceActivityType.STREAMING ), then
the ``url`` attribute is necessary.
When using this model to instantiate alongside the client, if you provide a type 1 ( or PresenceActivityType.STREAMING ),
then the ``url`` attribute is necessary.

The ``button`` attribute technically contains an object denoting Presence buttons. However, the gateway dispatches these
as strings (of button labels) as bots don't read the button URLs.

:ivar str name: The activity name
:ivar Union[int, PresenceActivityType] type: The activity type
Expand All @@ -126,7 +115,7 @@ class PresenceActivity(DictSerializerMixin):
:ivar Optional[PresenceSecrets] secrets?: for RPC join/spectate
:ivar Optional[bool] instance?: A status denoting if the activity is a game session
:ivar Optional[int] flags?: activity flags
:ivar Optional[List[PresenceButtons]] buttons?: Custom buttons shown in the RPC.
:ivar Optional[List[str]] buttons?: Custom button labels shown in the status, if any.
"""

name: str = field()
Expand All @@ -143,9 +132,7 @@ class PresenceActivity(DictSerializerMixin):
secrets: Optional[PresenceSecrets] = field(converter=PresenceSecrets, default=None)
instance: Optional[bool] = field(default=None)
flags: Optional[int] = field(default=None)
buttons: Optional[List[PresenceButtons]] = field(
converter=convert_list(PresenceButtons), default=None
)
buttons: Optional[List[str]] = field(default=None)
# TODO: document/investigate what these do.
user: Optional[Any] = field(default=None)
users: Optional[Any] = field(default=None)
Expand Down