refactor: create a ContextMixin class, and extract methods into there #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EepyElvyra
suggested changes
Feb 9, 2022
EepyElvyra
suggested changes
Feb 9, 2022
i0bs
suggested changes
Feb 18, 2022
1 task
i0bs
approved these changes
Feb 18, 2022
EepyElvyra
approved these changes
Feb 18, 2022
Contributor
EepyElvyra
left a comment
EepyElvyra
left a comment
There was a problem hiding this comment.
I read it like 10 times, I hope the code is fine
7 tasks
i0bs
pushed a commit
that referenced
this pull request
Feb 25, 2022
…#494) * refactor: create a ContextMixin class, and extract methods into there * docs: update context typehints and pyi file * ci: correct from checks. * fix: adjust payload creation * ci: correct from checks. * ci: correct from checks. * refactor: change ContextMixin to _Context * fix: forgotten name change Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request adds in a ContextMixin class, inheriting from DictSerializerMixin and designed to be used in the creation of new context classes
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.