Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't ignore allow_multiselect when serializing #1705

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

AstreaTSS
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Quick bugfix to make sure allow_multiselect is exported when serializing. Can't test right now, but the change is simple.

Changes

  • Remove no_export_meta from metadata of allow_multiselect.

Related Issues

Test Scenarios

import interactions as ipy

@ipy.slash_command()
async def test(ctx: ipy.SlashContext):
    poll = Poll.create("Test?", duration=1, answers=["1!", "2."], allow_multiselect=True)
    await ctx.send(poll=poll)

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary merged commit 3610f22 into interactions-py:unstable Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants