fix: hook onto add_command to propagate errors correctly #1678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Errors generated when adding prefixed and hybrid commands were not being propagated as they should, as due to being a separated extension, they would error out like a listener instead of like
add_command
. This caused some fun situations, like the one noted in #1668.This PR fixes that by adding a way of adding "hooks" onto
add_command
directly, and then making prefixed and hybrid commands use that hook for its register command logic.Changes
Client._add_command_hook
, which is a list of functions to run duringadd_command
.Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files