fix: adjust DistinctFlag.__call__ for python 3.12.3+ #1659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Due to a change allowing Enums to have None as a value, the default value has changed to support this feature. However this has broken the
DistinctFlag.__call__
used by interactions.py which explicity uses None as a name as the default making this a breaking change. By adjusting the function to not rely on a hard-coded default value we can support both a custom name as well as the new default while maintaining compatibility for old versions of pythonChanges
Adjusted
DistinctFlag.__call__
to call its super with kwargs that are previously defined based on the function call. If the default value is given, we throw them out, but if a non-default value is used, kwargs is filled with the ``names` parameter appropriately to be passed to the superRelated Issues
Fixes #1657
Test Scenarios
Python Compatibility
3.10.x
3.11.x
3.12.x
Checklist
pre-commit
code linter over all edited files