Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct expire property for interaction ctx #1624

Merged

Conversation

AstreaTSS
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Turns out BaseInteractionContext does not handle either expires_at or expired correctly. This PR fixes that.

Changes

  • Correct typehint of expires_at.
  • Make expires_at consider deferrals.
  • Make expired use Timestamp instead of naive datetime.

Related Issues

Fixes #1623.

Test Scenarios

import asyncio

@interactions.slash_command()
async def test(ctx: interactions.SlashContext):
    await ctx.defer()
    await asyncio.sleep(10)
    print(ctx.expired)  # should return false, but just errors out
    await ctx.send("Hello!")

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@AstreaTSS AstreaTSS merged commit 59a03f5 into interactions-py:unstable Mar 10, 2024
2 checks passed
@AstreaTSS AstreaTSS deleted the expires-fixes-interaction-ctx branch March 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants