fix: correctly work with Permissions.NONE when passed into Guild.create_role #1421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The
interactions.Guild.create_rolemethod does not work correctly if you pass ininteractions.Permissions.NONE. Rather than creating the role in Discord with every permission disabled, it instead creates the role with discord's default permissions enabled.Changes
interactions.Guild.create_rolemethodpermissionsto the payload to check equality tointeractions.Permissions.NONEin addition to truthy valuesRelated Issues
fixes #1420
Test Scenarios
137408993025601(discord's default)0I didn't add any unit tests because it seemed like overkill for such a small edge case. But I can add one in if folks disagree.
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files