Skip to content

Conversation

@rdni
Copy link
Contributor

@rdni rdni commented May 21, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Changed the example bot to make it function correctly as well as have up to date information on the docs

Changes

  • Changed the docs link to be up to date
  • Added the message content intent.
  • Changed the parameter for the message listen from "interactions.Message" to "interactions.api.events.MessageCreate".

Related Issues

Test Scenarios

No tests are required as it is not changing the library it self

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

rdni and others added 2 commits May 21, 2023 19:25
Added the message content intent, so that the event listener works correctly, and changed the parameter for the message listen from "interactions.Message" to "interactions.api.events.MessageCreate" to fix the event.

Signed-off-by: redninja9854 <[email protected]>
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good start - just need a couple of wording adjustments (and one code change).

@AstreaTSS AstreaTSS changed the title Fix errors in the bot example and add intent docs: fix errors in the bot example and add intent May 22, 2023
rdni and others added 2 commits May 22, 2023 07:54
Reduce confusion when reading the comments

Signed-off-by: redninja9854 <[email protected]>
rdni and others added 3 commits May 24, 2023 17:05
Changed the comment explaining what message create was to make it clearer.

Signed-off-by: redninja9854 <[email protected]>
@LordOfPolls LordOfPolls merged commit 00bfe2b into interactions-py:unstable May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants