-
Notifications
You must be signed in to change notification settings - Fork 185
feat: add in hybrid slash commands #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77601ab to
d00e97d
Compare
|
Ready for testing. Do note the extent of these changes - as with the original hybrid command PR from a while back, testing everything is impossible and there's likely plenty of bugs right now. |
589a9e2 to
3529881
Compare
AstreaTSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping. Two developers from the Discord server have said it's stable for them - I think this is safe to merge.
Still relatively untested. Needs a lot of polish.
2f34bc3 to
5603008
Compare
|
Rebased! Also did a tiny adjustment to the title of the hybrid command section to note how prefixed commands are often called text commands. |
This threw the prefixed command parser in for a loop.
This wasn't matching slash command behavior
Pull Request Type
Description
Adds (back) hybrid slash commands, which makes it easy to make and use a prefixed command from a standard slash command. This is based off the old NAFF implementation, though improvements have been made where possible.
Changes
It's hybrid commands.
HybridSlashCommandand the command that transforms a slash command to a prefixed command.HybridContextfor nice interop between the two types of commands.Related Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files