Skip to content

Conversation

@mAxYoLo01
Copy link
Contributor

About

This bug was found on the support server.
Basically, some objects do not have the HTTPClient passed through when getting the objects from the cache. This PR makes sure that, if the object is found in cache, it has the HTTPClient added to it.

PS: The get() function is a pain to debug, I would like to suggest to rewrite it in a way that it will be less hard for the next contributor to fix it.

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

@Damego Damego added the bug Something isn't working label Dec 12, 2022
@mAxYoLo01 mAxYoLo01 requested a review from Damego December 12, 2022 12:56
@Damego Damego merged commit 7684c7c into interactions-py:unstable Dec 12, 2022
@mAxYoLo01 mAxYoLo01 deleted the fix-get branch December 12, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants