fix: Pass HTTPClient to all objects when using get() with cache. #1196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This bug was found on the support server.
Basically, some objects do not have the HTTPClient passed through when getting the objects from the cache. This PR makes sure that, if the object is found in cache, it has the HTTPClient added to it.
PS: The
get()function is a pain to debug, I would like to suggest to rewrite it in a way that it will be less hard for the next contributor to fix it.Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: