Skip to content

Conversation

@GeomKid
Copy link
Contributor

@GeomKid GeomKid commented Nov 27, 2022

About

This pull request is about add defered_ephemeral property, which does .

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

@GeomKid GeomKid requested a review from EepyElvyra November 27, 2022 17:39
@EepyElvyra
Copy link
Contributor

Also please test it

@EepyElvyra EepyElvyra added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 27, 2022
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well make defer return the message object now

GeomKid and others added 2 commits November 28, 2022 02:35
Co-authored-by: EdVraz <[email protected]>
Co-authored-by: EdVraz <[email protected]>
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its fine now

@EepyElvyra EepyElvyra merged commit bc00b54 into interactions-py:unstable Nov 27, 2022
@GeomKid GeomKid deleted the interactions-py-unstable branch November 28, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants