bugfix typo: fixes cert-manager#26

Signed-off-by: Tim Ramlot <[email protected]>
inteon · Mar 4, 2024 · cda995f · cda995f
1 parent 9ab4727
commit cda995f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pkg/inspect/secret/secret.go b/pkg/inspect/secret/secret.go
@@ -57,13 +57,13 @@ const validityPeriodTemplate = `Validity period:
 
 const issuedByTemplate = `Issued By:
 	Common Name:	{{ .CommonName }}
-	Organization:	{{ .CommonName }}
+	Organization:	{{ .Organization }}
 	OrganizationalUnit:	{{ .OrganizationalUnit }}
 	Country:	{{ .Country }}`
 
 const issuedForTemplate = `Issued For:
 	Common Name:	{{ .CommonName }}
-	Organization:	{{ .CommonName }}
+	Organization:	{{ .Organization }}
 	OrganizationalUnit:	{{ .OrganizationalUnit }}
 	Country:	{{ .Country }}`
 
@@ -219,7 +219,7 @@ func describeIssuedBy(cert *x509.Certificate) string {
 	}{
 		CommonName:         printOrNone(cert.Issuer.CommonName),
 		Organization:       printSliceOrOne(cert.Issuer.Organization),
-		OrganizationalUnit: printSliceOrOne(cert.Issuer.Organization),
+		OrganizationalUnit: printSliceOrOne(cert.Issuer.OrganizationalUnit),
 		Country:            printSliceOrOne(cert.Issuer.Country),
 	})
 
@@ -236,7 +236,7 @@ func describeIssuedFor(cert *x509.Certificate) string {
 	}{
 		CommonName:         printOrNone(cert.Subject.CommonName),
 		Organization:       printSliceOrOne(cert.Subject.Organization),
-		OrganizationalUnit: printSliceOrOne(cert.Subject.Organization),
+		OrganizationalUnit: printSliceOrOne(cert.Subject.OrganizationalUnit),
 		Country:            printSliceOrOne(cert.Subject.Country),
 	})
 

diff --git a/pkg/inspect/secret/secret_test.go b/pkg/inspect/secret/secret_test.go
@@ -83,7 +83,6 @@ func init() {
 		gen.SetCertificateIPs("10.0.0.1"),
 		gen.SetCertificateURIs("spiffe://cert-manager.test"),
 		gen.SetCertificateEmails("[email protected]"),
-		gen.SetCertificateIsCA(true),
 		gen.SetCertificateKeyAlgorithm(v1.ECDSAKeyAlgorithm),
 		gen.SetCertificateIsCA(false),
 		gen.SetCertificateKeySize(256),
@@ -222,7 +221,7 @@ func Test_describeIssuedBy(t *testing.T) {
 			want: `Issued By:
 	Common Name:	testing-ca
 	Organization:	testing-ca
-	OrganizationalUnit:	Internet Widgets, Inc.
+	OrganizationalUnit:	WWW
 	Country:	US`,
 		},
 	}