This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Stopping a task with plugin initiated workflow should not panic #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IzabellaRaulin, do you mind open an issue with the steps to reproduce this issue? |
|
@candysmurf, I created #1589 - there you can find step by step how to reproduce that issue |
jcooklin
reviewed
Apr 5, 2017
control/available_plugin.go
Outdated
| @@ -236,7 +236,7 @@ func (a *availablePlugin) Stop(r string) error { | |||
| return a.client.Kill(r) | |||
| } | |||
|
|
|||
| // Kill assumes aplugin is not able to here a Kill RPC call | |||
| // Kill assumes a plugin is not able to here a Kill RPC call | |||
There was a problem hiding this comment.
good catch - I changed it to "hear"
| t.state = core.TaskStopped | ||
| break | ||
| t.Unlock() | ||
| done = true |
There was a problem hiding this comment.
After removing g.killed() in control/plugin/client/grpc.go, where are we closing the channel to be able to receive "closing of killChan" here?
There was a problem hiding this comment.
It works exactly in the same way as for regular spin() - so it happens here: https://github.com/intelsdi-x/snap/blob/master/scheduler/task.go#L360
IzabellaRaulin
force-pushed
the
fix_streaming_killed_two_times
branch
from
ed6ab41
to
e1c8da6
Compare
|
LGTM |
|
Thank You |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1589
Before:
Stopping a task with streaming schedule caused a panic:
After
Stopping the task behaves as expected:
Summary of changes:
doneto true after receiving that killChan has been Closedg.Killed()from control/plugin/client/grpc.go because:Testing done:
@intelsdi-x/snap-maintainers