Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Plugins should be unsubscribed by the event handler after the task state is Stopped #1601

Closed
rashmigottipati opened this issue Apr 12, 2017 · 0 comments

Comments

@rashmigottipati
Copy link
Contributor

Current behavior:
When a stop task request is processed by the scheduler, it immediately starts unsubscribing all dependencies (plugins) of this task. This results in the plugins being used by the current firing of the workflow being killed.

Desired behavior:
Plugins should be unsubscribed after the task state is changed to Stopped state. There is an intermediate state between firing and stopped (i.e. Stopping). When the task state is changed to stopping, we close the channel "killchan" and closing of this killchan is received in the spin go routine. Changing of task state from stopping to stopped takes place here. So, plugins should be unsubscribed:

  • By the event handler in scheduler
  • After task state is changed to stopped (meaning that the task is truly stopped and the workflow finished executing)
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 12, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 13, 2017
rashmigottipati added a commit that referenced this issue Apr 13, 2017
Fixes #1598 and #1601 - ability to stop tasks gracefully
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant