Skip to content

Commit

Permalink
fix(CI): Call python to upgrade pip on Windows (XRPLF#4768)
Browse files Browse the repository at this point in the history
In Windows, we need to call `python` in order for the `pip` upgrade
command to work.

This changes the GitHub Actions Windows CI job to use the correct
command to upgrade PIP, fixing this error:

```
ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe -m pip install --upgrade pip
```

A future task is to make job run on heavy Windows runners so that it
doesn't take so long.

Context: XRPLF#4596
  • Loading branch information
ximinez authored Oct 16, 2023
1 parent c915984 commit 1fde585
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
id: pip-cache
shell: bash
run: |
pip install --upgrade pip
python -m pip install --upgrade pip
echo "dir=$(pip cache dir)" | tee ${GITHUB_OUTPUT}
- name: restore Python cache directory
uses: actions/cache@v3
Expand Down

0 comments on commit 1fde585

Please sign in to comment.