-
Notifications
You must be signed in to change notification settings - Fork 64
Gemm Universal unit tests for MainloopIntelW8A8 API #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive unit test coverage for Intel GPU FP8 GEMM operations using the MainloopIntelW8A8 dispatch policy. The tests validate FP8→FP32 matrix multiplication kernels on Intel Xe XMX architecture across various workload scenarios.
Key changes:
- Added 14 unit tests covering LLM model configurations (LLaMA2-7B, Mistral-7B), parallelization strategies, and various matrix dimensions
- Introduced new
TestXeoverload accepting explicit batch parameter for batched GEMM operations - Integrated new test file into CMake build system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gemm_universal_fp8_fp8_fp32_tensor_op_f32_xe_models.cpp | New test file with 14 test cases covering model-specific and edge-case GEMM configurations |
| gemm_testbed_3x.hpp | Added TestXe overload with explicit batch size parameter and enhanced error reporting |
| CMakeLists.txt | Added new test file to SYCL-enabled build targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | ||
| throw; | ||
| } | ||
| catch (...) { | ||
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception"; |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 'EXPECT_TRUE(false)' is an anti-pattern. Replace with 'FAIL()' or 'ADD_FAILURE()' for clearer intent and better test failure messages in Google Test.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception"; | |
| FAIL() << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| FAIL() << "TestXe: testbed.run threw an unknown exception"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copilot is wrong with FAIL. ADD_FAILURE might be slightly better but I'm OK either way.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | ||
| throw; | ||
| } | ||
| catch (...) { | ||
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception"; |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 'EXPECT_TRUE(false)' is an anti-pattern. Replace with 'FAIL()' or 'ADD_FAILURE()' for clearer intent and better test failure messages in Google Test.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception"; | |
| FAIL() << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| FAIL() << "TestXe: testbed.run threw an unknown exception"; |
Unit tests for MainloopIntelW8A8 FP8 GEMM operations on Intel Xe
Comprehensive test coverage for Intel GPU FP8 GEMM kernels including:
Tests validate
MainloopIntelW8A8dispatch policy with FP8→FP32 precision on Intel Xe XMX architecture.