forked from NVIDIA/cutlass
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 64
Re-implement FlashAttention with new Xe atoms #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            petercad
  wants to merge
  11
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
petercad/rearch_sdpa
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +2,755
        
        
          −39
        
        
          
        
      
    
  
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      b693094
              
                [Xe] Refactor split barrier functionality
              
              
                petercad f34c74f
              
                [CuTe] [Xe] Reorder fixes/extensions for f32 -> bf16
              
              
                petercad 96d2959
              
                [CuTe] [Xe] Allow size-1 fragments in block 2D copies
              
              
                petercad 298a883
              
                [CuTe] [Xe] Copy fixes
              
              
                petercad 1b5e21b
              
                [CuTe] [Xe] make_block_2d_copy_{C,D} variants with subtiling
              
              
                petercad 1fa2b61
              
                [CuTe] Minor layout features/fixes
              
              
                petercad c475492
              
                [CuTe] [Xe] New make_subgroup_tensor helpers
              
              
                petercad 22993de
              
                [CuTe] [Xe] Subgroup-scope broadcast/reduction
              
              
                petercad cc6d10d
              
                [Platform] Add missing numeric_limits<float>::lowest()
              
              
                petercad 460d34a
              
                [Xe] Re-implement FlashAttention with new atoms
              
              
                petercad 2bb6829
              
                [Xe] Additional comments
              
              
                petercad File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
        
          
          
            169 changes: 169 additions & 0 deletions
          
          169 
        
  applications/flash_attention_v2/collective/copy_block_slm.hpp
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| /*************************************************************************************************** | ||
| * Copyright (C) 2025 Intel Corporation, All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * 1. Redistributions of source code must retain the above copyright notice, this | ||
| * list of conditions and the following disclaimer. | ||
| * | ||
| * 2. Redistributions in binary form must reproduce the above copyright notice, | ||
| * this list of conditions and the following disclaimer in the documentation | ||
| * and/or other materials provided with the distribution. | ||
| * | ||
| * 3. Neither the name of the copyright holder nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
| * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
| * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
| * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| **************************************************************************************************/ | ||
|  | ||
| #pragma once | ||
|  | ||
| namespace cute { | ||
|  | ||
| /* Flat copies */ | ||
| template <class SrcEngine, class SrcLayout, | ||
| class DstEngine, class DstLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_r2s(Tensor<SrcEngine, SrcLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> & dst) | ||
| { | ||
| static_assert(is_rmem_v<SrcEngine> && is_smem_v<DstEngine>, "Expected rmem->smem copy"); | ||
|  | ||
| auto atom_r2s = Copy_Atom<XE_1D_STSM<float>, float>{}; // TODO: larger block messages | ||
|  | ||
| auto atom_shape = make_shape(_1{}, size(src)); | ||
| auto src_v = src.compose(make_layout(atom_shape)); | ||
| auto dst_v = dst.compose(make_layout(atom_shape, Stride<_0, _16>{})); | ||
|  | ||
| copy(atom_r2s, src_v, dst_v); | ||
| } | ||
|  | ||
| template <class SrcEngine, class SrcLayout, | ||
| class DstEngine, class DstLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_s2r(Tensor<SrcEngine, SrcLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> & dst) | ||
| { | ||
| static_assert(is_smem_v<SrcEngine> && is_rmem_v<DstEngine>, "Expected smem->rmem copy"); | ||
|  | ||
| auto atom_s2r = Copy_Atom<XE_1D_LDSM<float>, float>{}; | ||
|  | ||
| auto atom_shape = make_shape(_1{}, size(dst)); | ||
| auto src_v = src.compose(make_layout(atom_shape, Stride<_0, _16>{})); | ||
| auto dst_v = dst.compose(make_layout(atom_shape)); | ||
|  | ||
| copy(atom_s2r, src_v, dst_v); | ||
| } | ||
|  | ||
| /* Coordinate-aware copies */ | ||
| template <class SrcEngine, class SrcLayout, class SrcCoordLayout, | ||
| class DstEngine, class DstLayout, class DstCoordLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_r2s(SubgroupTensor<SrcEngine, SrcLayout, SrcCoordLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> & dst, | ||
| DstCoordLayout const& dst_c) | ||
| { | ||
| using _SG = intel::_SGSize; | ||
|  | ||
| static_assert(is_rmem_v<SrcEngine> && is_smem_v<DstEngine>, "Expected rmem->smem copy"); | ||
| static_assert(sizeof_bits_v<typename SrcEngine::value_type> == 32, "Only 32-bit data supported"); | ||
|  | ||
| auto atom_r2s = Copy_Atom<XE_1D_STSM<float>, float>{}; // TODO: larger block messages | ||
|         
                  petercad marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
|  | ||
| auto atom_shape = make_shape(_1{}, size(SrcLayout{})); | ||
|  | ||
| auto src_c_wi0 = composition(project_strides(SrcCoordLayout{}), make_layout(atom_shape, Stride<_0, _SG>{})); | ||
| auto rlayout = composition(right_inverse(project_strides(dst_c)), src_c_wi0); | ||
|  | ||
| auto src_v = src.compose(make_layout(atom_shape)); | ||
| auto dst_v = dst.compose(rlayout); | ||
|  | ||
| copy(atom_r2s, src_v, dst_v); | ||
| } | ||
|  | ||
| template <class SrcEngine, class SrcLayout, class SrcCoordLayout, | ||
| class DstEngine, class DstLayout, class DstCoordLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_s2r(Tensor<SrcEngine, SrcLayout> const& src, | ||
| SrcCoordLayout const& src_c, | ||
| SubgroupTensor<DstEngine, DstLayout, DstCoordLayout> & dst) | ||
| { | ||
| using _SG = intel::_SGSize; | ||
|  | ||
| static_assert(is_smem_v<SrcEngine> && is_rmem_v<DstEngine>, "Expected smem->rmem copy"); | ||
| static_assert(sizeof_bits_v<typename SrcEngine::value_type> == 32, "Only 32-bit data supported"); | ||
|  | ||
| auto atom_s2r = Copy_Atom<XE_1D_LDSM<float>, float>{}; | ||
|  | ||
| auto atom_shape = make_shape(_1{}, size(DstLayout{})); | ||
|  | ||
| auto dst_c_wi0 = composition(project_strides(DstCoordLayout{}), make_layout(atom_shape, Stride<_0, _SG>{})); | ||
| auto rlayout = composition(right_inverse(project_strides(src_c)), dst_c_wi0); | ||
|  | ||
| auto src_v = src.compose(rlayout); | ||
| auto dst_v = dst.compose(make_layout(atom_shape)); | ||
|  | ||
| copy(atom_s2r, src_v, dst_v); | ||
| } | ||
|  | ||
| /* Variants accepting rvalue dst */ | ||
| template <class SrcEngine, class SrcLayout, | ||
| class DstEngine, class DstLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_r2s(Tensor<SrcEngine, SrcLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> && dst) | ||
| { | ||
| return copy_block_r2s(src, dst); | ||
| } | ||
|  | ||
| template <class SrcEngine, class SrcLayout, | ||
| class DstEngine, class DstLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_s2r(Tensor<SrcEngine, SrcLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> && dst) | ||
| { | ||
| return copy_block_s2r(src, dst); | ||
| } | ||
|  | ||
| template <class SrcEngine, class SrcLayout, class SrcCoordLayout, | ||
| class DstEngine, class DstLayout, class DstCoordLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_r2s(SubgroupTensor<SrcEngine, SrcLayout, SrcCoordLayout> const& src, | ||
| Tensor<DstEngine, DstLayout> && dst, | ||
| DstCoordLayout const& dst_c) | ||
| { | ||
| return copy_block_r2s(src, dst, dst_c); | ||
| } | ||
|  | ||
| template <class SrcEngine, class SrcLayout, class SrcCoordLayout, | ||
| class DstEngine, class DstLayout, class DstCoordLayout> | ||
| CUTE_HOST_DEVICE | ||
| void | ||
| copy_block_s2r(Tensor<SrcEngine, SrcLayout> const& src, | ||
| SrcCoordLayout const& src_c, | ||
| SubgroupTensor<DstEngine, DstLayout, DstCoordLayout> && dst) | ||
| { | ||
| return copy_block_s2r(src, dst); | ||
| } | ||
|  | ||
| } /* namespace cute */ | ||
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here? This isn't flash attention specific, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not. These started as some simple helpers to make copying to/from SLM easier for the epilogue. We could move them, maybe to
include/cute/algorithm/cute.hpp, though they should be made more sophisticated (use smaller/larger block sizes as appropriate, automatic fallback to scatter/gather, etc.).