Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refine for ros2 branch #253

Merged
merged 28 commits into from
Dec 22, 2022
Merged

Conversation

ChloeWu1
Copy link
Contributor

@ChloeWu1 ChloeWu1 commented Dec 9, 2022

Signed-off-by: Wu, Jiawei [email protected]

@gitpqLee
Copy link
Contributor

@LewisLiuPub Could please help to review this PR? which update docs. Thx

@LewisLiuPub
Copy link
Contributor

branch foxy keeps for foxy and openvino 2021.4LTS, so the related doc should also be kept.
branch dashing is deprecated, but we will keep it for a span of time, so the related doc also needs to keep.

Copy link
Contributor

@LewisLiuPub LewisLiuPub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the new review comments.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@LewisLiuPub
Copy link
Contributor

LGTM.

@LewisLiuPub LewisLiuPub merged commit ccd1aed into intel:ros2 Dec 22, 2022
LewisLiuPub added a commit that referenced this pull request Apr 21, 2023
* Adding the jenkinsfile for galactic branch

Signed-off-by: huangjiafengx <[email protected]>

* Updating the Jenkinsfile for PR test

Signed-off-by: huangjiafengx <[email protected]>

* Enable environment information for email.

Signed-off-by: huangjiafengx <[email protected]>

* Upgrade Code to support OpenVINO API2.0 (ver 2022.1/2)

* adapt API 2.0 for engines

Signed-off-by: Fan, Tao <[email protected]>

* fix callback

Signed-off-by: Fan, Tao <[email protected]>

* base model: fix read model api

Signed-off-by: Fan, Tao <[email protected]>

* fix start interence api

Signed-off-by: Fan, Tao <[email protected]>

* fix updateLayerProperty parameter type

Signed-off-by: Fan, Tao <[email protected]>

* adapt API2022.1

* fix inputinfo

* fix inputinfo of segmentation model

* fix version api

* fix header files

* fix get tensor of base_inference header file

* fix version info

Signed-off-by: Fan,Tao <[email protected]>

* adapt for object segmentation inferences API

Signed-off-by: Fan,Tao <[email protected]>

* fix object segmentation enqueue and updateLayerProperty

Signed-off-by: Fan,Tao <[email protected]>

* fix person_attribs_detection

* age_gender_detection

* fix age_gender_detection

* fix face detection and object detection(ssd)

Signed-off-by: Fan,Tao <[email protected]>

* fix emotions_detenction_model

* fix variable name

* fix updateLayerProperty param type

* fix head_pose_detection

* fix license plate detection

Signed-off-by: Fan,Tao <[email protected]>

* fix vehicle attribs detection

Signed-off-by: Fan,Tao <[email protected]>

* fix person_attribs_detection_model

* fix base_attribute

* fix object detection(yolov2)

* fix person_reidentification and ssd_model_attr

* fix age gender detection

Signed-off-by: Fan,Tao <[email protected]>

* fix emotions_detection

* fix head pose detection

Signed-off-by: Fan,Tao <[email protected]>

* fix person reidentification

Signed-off-by: Fan,Tao <[email protected]>

* fix person_attribs_detection

* more fix to object segmentation, still bug

Signed-off-by: Fan,Tao <[email protected]>

* update quick_start_doc for Galactic_Ubuntu20.04

* update quick_start_doc for Galactic_Ubuntu20.04_ov2.0

* Revert "update quick_start_doc for Galactic_Ubuntu20.04"

This reverts commit 2e5646c.

* fix segmentation typo and correct fetch output

Signed-off-by: Fan,Tao <[email protected]>

* clean up code and fix typo

Signed-off-by: Fan,Tao <[email protected]>

* fix CMakeLists

* add NCHW and NHWC layout compatibility for object_segmentation and object_detection_ssd model

Signed-off-by: Fan, Tao <[email protected]>

* fix doc for branch galactic ov2.0

* clean code and fix CMakeLists

* code refine: move input&output info definition to base attribute

Signed-off-by: Fan, Tao <[email protected]>

* fix typo

* fix param name for new API

* fix param name getModel

* fix typo

* add mkdir for label

Signed-off-by: Fan, Tao <[email protected]>
Signed-off-by: Fan,Tao <[email protected]>
Co-authored-by: wujiawei <[email protected]>

* add dockerfile and instruction (#247)

* add dockerfile and instruction

* add build arg of proxy

* add model lists for omz tools and fix instruction

* add lsb param and declare support version

* remove opencv4.5.5 install

* Add the pipeline of segmentation_maskrcnn (#249)

* upgrade maskrcnn

* add maskrcnn segmentation

* add output

* fix class name

* fix pipeline manager and output

* fix segmentation pipeline

* Update ros2 doc for quick start (#248)

* update ros2 doc for quick start

* fix typo

* fix yaml model path

* fix vehicle attribs and license plate (#252)

Signed-off-by: Fan, Tao <[email protected]>

Signed-off-by: Fan, Tao <[email protected]>

* Enable klocwork checking for Jenkins CI (#250)

Signed-off-by: huangjiafengx <[email protected]>

* Update Documents and related build files (#253)

* refine for docker

* refine to adapt humble

* fix doc and yaml path

* fix the structure of ros2 document and add yaml configuration guide

* add the table of contents in README

* fix link

* refine for format and capital letter

* add reference link for installation

* add model and yaml link for inference table

* add table for the corresponding relation of ros2 branches

* add links to the table of contents and refine docker instruction

* update yaml configuration and add tables

* update yaml configuration

* update README format

* update README format

* add FAQ module

* update structure of table content

* update Inference Implementations table in README

* update

* update table format

* update

* refine format and add tables in README

* add feedback module in README

* fix typo in README

* add prerequisite table and fix links

* fix for topic table

* fix typo

* add link

* Support yolov5n (#256)

* initial code for supporting yolov5n

Signed-off-by: Fan,Tao <[email protected]>

* fix code for supporting yolov5n

* fix code for yolov5n

* revert code for resize image

* fix for docker

* fix model used for people reidentification

* fix copyright 2018-2022

* fix bug for person attribs detection

* add doc for yolov5 converted

---------

Signed-off-by: Fan,Tao <[email protected]>
Co-authored-by: Fan,Tao <[email protected]>

* Fixing the bug of conflict resources for Jenkins CI (#257)

* Enable klocwork checking for Jenkins CI

Signed-off-by: huangjiafengx <[email protected]>

* Fix the bug of conflict resources for Jenkins CI

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: huangjiafengx <[email protected]>

* rename package for release

* rename to openvino_node

* disable face reidentification pipeline

* rename package for release (#258)

* rename package for release

* rename to openvino_node

* Update the openvino2022.1 to 2022.3 for the docker (#264)

Signed-off-by: huangjiafengx <[email protected]>

* Enable GitHub action ci (#267)

* Enable the ros2 openvino toolkit CI test for Github action

Signed-off-by: huangjiafengx <[email protected]>

* Add the ci launch file

Signed-off-by: huangjiafengx <[email protected]>

* Update ros2_branch.yml

* Add the log file

Signed-off-by: huangjiafengx <[email protected]>

* Enable GitHub action CI

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: huangjiafengx <[email protected]>

* Setting the version for XTestRunner update. (#268)

* Fix segmentation (#269)

* update code to align with new version of maskrcnn segmentation model (layout=NHWC)

Signed-off-by: Liu, Wei Zhi <[email protected]>

* update code to align with new version of deeplabv3 segmentation model.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Update run.sh (#270)

* fix build error.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* update yaml file to use new version of maskrcnn segmentation model.

Signed-off-by: Liu, Wei Zhi <[email protected]>

---------

Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: huangjiafengx <[email protected]>

* Use object_msgs instead of openvino_people_msgs (#265)

* use object_msgs instead of openvino_people_msgs.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* update README by using object_msgs instead of openvino_people_msgs

Signed-off-by: Liu, Wei Zhi <[email protected]>

---------

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Enable segmentation and yolov5 for github action. (#271)

* Add the segmentation CI test for github action

Signed-off-by: huangjiafengx <[email protected]>

* Enable the segmentation cases for Github Action CI.

Signed-off-by: huangjiafengx <[email protected]>

* Enable the segmentation cases for Github Action CI.

Signed-off-by: huangjiafengx <[email protected]>

* Enable the segmentation cases for Github Action CI.

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: huangjiafengx <[email protected]>

* Update the Document for openvino version (#272)

Signed-off-by: huangjiafengx <[email protected]>

* Enable ci for master (#274)

* update CI configurations to support branch master

Signed-off-by: Liu, Wei Zhi <[email protected]>

* fix issues on the file Dockerfile for CI caes.

Signed-off-by: huangjiafengx <[email protected]>

* Fix GitHub action ci issue (#276)

* Enable ci for master

Signed-off-by: huangjiafengx <[email protected]>

* Sloving the Github action CI fail.

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: Liu, Wei Zhi <[email protected]>
Signed-off-by: huangjiafengx <[email protected]>
Co-authored-by: huangjiafengx <[email protected]>

* Removing the picture no using. (#277)

Signed-off-by: huangjiafengx <[email protected]>

---------

Signed-off-by: huangjiafengx <[email protected]>
Signed-off-by: Fan, Tao <[email protected]>
Signed-off-by: Fan,Tao <[email protected]>
Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: huangjiafengx <[email protected]>
Co-authored-by: Fan,Tao <[email protected]>
Co-authored-by: wujiawei <[email protected]>
Co-authored-by: Fan,Tao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants