-
Notifications
You must be signed in to change notification settings - Fork 33
FixedPoint is now a LogicStructure with a Populator #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Jun 9, 2025
mkorbel1
reviewed
Jun 10, 2025
|
What is the technique for linking issues. I add '# to my starting comment, but then I notice you later 'link' the issue. |
There's some keywords, e.g. you can put the word "fix" before them |
mkorbel1
approved these changes
Jun 20, 2025
mkorbel1
approved these changes
Jun 25, 2025
mkorbel1
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
We wanted FixedPoint to be a LogicStructure and to follow the new patterns for FloatingPoint in particular the populator pattern.
Related Issue(s)
#184
Testing
Ran existing Fixed point tests after refactoring to change both FixedPoint and FixedPointValue.
Backwards-compatibility
No.
Documentation
These are internals. There may be a reference in the documentation about FixedPoint being a Logic which will need updating.