Skip to content

Conversation

@desmonddak
Copy link
Contributor

Description & Motivation

We wanted FixedPoint to be a LogicStructure and to follow the new patterns for FloatingPoint in particular the populator pattern.

Related Issue(s)

#184

Testing

Ran existing Fixed point tests after refactoring to change both FixedPoint and FixedPointValue.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

These are internals. There may be a reference in the documentation about FixedPoint being a Logic which will need updating.

@desmonddak desmonddak requested a review from mkorbel1 June 8, 2025 13:38
@mkorbel1 mkorbel1 linked an issue Jun 10, 2025 that may be closed by this pull request
@desmonddak
Copy link
Contributor Author

What is the technique for linking issues. I add '# to my starting comment, but then I notice you later 'link' the issue.

@mkorbel1
Copy link
Contributor

What is the technique for linking issues. I add '# to my starting comment, but then I notice you later 'link' the issue.

There's some keywords, e.g. you can put the word "fix" before them

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@mkorbel1 mkorbel1 merged commit d9e8803 into intel:main Jun 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FixedPoint should be a LogicStructure

2 participants