Add parsing of OpenCL C++ -cl-std flags #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2024
wenju-he
reviewed
May 7, 2024
| @@ -231,7 +243,9 @@ std::string EffectiveOptionsFilter::processOptions(const OpenCLArgList &args, | |||
|
|
|||
| // Specifying the option makes clang emit function body for functions | |||
| // marked with inline keyword. | |||
| effectiveArgs.push_back("-fgnu89-inline"); | |||
| if (!isCpp) { | |||
There was a problem hiding this comment.
@lucasz93 why is option -fgnu89-inline not needed for OpenCL C++?
There was a problem hiding this comment.
I ran into a compiler error with that flag, which was previously reported as an issue here. Looks like not supporting -fgnu87-inline is expected behaviour according to the reply:
This is intentional. In C++ and C++-based language, we can't reasonably support "-fgnu89-inline"; we always use the C++ inline rules.
So I disabled it in C++ mode for opencl-clang.
|
@wenju-he can we have this change backported to |
sure, I'll do it and port to 150/160/170/180 branches as well. |
wenju-he
pushed a commit
to wenju-he/opencl-clang
that referenced
this pull request
May 16, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](intel#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145)
wenju-he
pushed a commit
to wenju-he/opencl-clang
that referenced
this pull request
May 16, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](intel#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145)
wenju-he
pushed a commit
to wenju-he/opencl-clang
that referenced
this pull request
May 16, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](intel#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145)
wenju-he
pushed a commit
to wenju-he/opencl-clang
that referenced
this pull request
May 16, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](intel#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145)
wenju-he
pushed a commit
to wenju-he/opencl-clang
that referenced
this pull request
May 16, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](intel#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145)
This was referenced May 17, 2024
haonanya
pushed a commit
that referenced
this pull request
May 17, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145) Co-authored-by: lucasz93 <[email protected]>
haonanya
pushed a commit
that referenced
this pull request
May 17, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145) Co-authored-by: lucasz93 <[email protected]>
haonanya
pushed a commit
that referenced
this pull request
May 17, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145) Co-authored-by: lucasz93 <[email protected]>
haonanya
pushed a commit
that referenced
this pull request
May 17, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145) Co-authored-by: lucasz93 <[email protected]>
haonanya
pushed a commit
that referenced
this pull request
May 17, 2024
Hello! Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: [intel-graphics-compiler](intel/intel-graphics-compiler#328), [compute-runtime](intel/compute-runtime#731) and [opencl-clang](#510). The options are passed down into LLVM which then happily compiles my C++ kernel. PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime. Kind regards, -Lucas Co-authored-by: Lucas Zadrozny <[email protected]> (cherry picked from commit 545a145) Co-authored-by: lucasz93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Support for OpenCL C++ was added into LLVM 14, but IGC doesn't support parsing of those flags just yet. I've opened PRs which adds support for parsing these flags to the following repositories: intel-graphics-compiler, compute-runtime and opencl-clang.
The options are passed down into LLVM which then happily compiles my C++ kernel.
PRs should be merged in the following order: opencl-clang, intel-graphics-compiler, then finally compute-runtime.
Kind regards,
-Lucas