Sync msft 24 7 25 - #760
reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (8)
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h|11| Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h|12| Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h|308| Add #include for min_element [build/include_what_you_use] [4]
onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h|25| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h|31| Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|251| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|267| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/session/provider_bridge_ort.cc|1820| Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
Filtered Findings (0)
Annotations
Check notice on line 11 in onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h#L11
Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h:11: Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
Check notice on line 12 in onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h#L12
Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h:12: Found C++ system header after other header. Should be: tree_ensemble_attribute.h, c system, c++ system, other. [build/include_order] [4]
Check notice on line 308 in onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h#L308
Add #include <algorithm> for min_element [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h:308: Add #include <algorithm> for min_element [build/include_what_you_use] [4]
Check notice on line 25 in onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h#L25
Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h:25: Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
Check notice on line 31 in onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h#L31
Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/cpu/ml/tree_ensemble_common.h:31: Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
Check notice on line 251 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L251
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:251: Add #include <string> for string [build/include_what_you_use] [4]
Check notice on line 267 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L267
Add #include <memory> for make_unique<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:267: Add #include <memory> for make_unique<> [build/include_what_you_use] [4]
Check notice on line 1820 in onnxruntime/core/session/provider_bridge_ort.cc
github-actions / cpplint
[cpplint] onnxruntime/core/session/provider_bridge_ort.cc#L1820
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
Raw output
onnxruntime/core/session/provider_bridge_ort.cc:1820: Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]