Skip to content

Sync ort main 19 7 25#749

Merged
ankitm3k merged 22 commits into
ovep-developfrom
sync_ort_main_19_7_25
Jul 19, 2025
Merged

Sync ort main 19 7 25#749
ankitm3k merged 22 commits into
ovep-developfrom
sync_ort_main_19_7_25

Merge branch 'master' into sync_ort_main_19_7_25

8642e8b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / cpplint completed Jul 19, 2025 in 1s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (39)

include/onnxruntime/core/session/environment.h|200| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc|14| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc|80| Add #include for string [build/include_what_you_use] [4]
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc|226| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.h|13| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/core/framework/allocator.cc|21| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/core/framework/plugin_ep_stream.cc|10| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/framework/plugin_ep_stream.cc|15| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/framework/plugin_ep_stream.h|103| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/core/optimizer/transpose_optimization/ort_transpose_optimization.cc|8| Found C system header after C++ system header. Should be: ort_transpose_optimization.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/cann/cann_utils.cc|237| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/cann/cann_utils.h|12| is an unapproved C++17 header. [build/c++17] [5]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|11| Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|12| Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|396| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|528| Using C-style cast. Use reinterpret_cast<OrtDataTransferImpl*>(...) instead [readability/casting] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|669| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|872| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/providers/cuda/cuda_provider_factory.cc|920| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc|232| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc|248| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|608| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|2344| Using C-style cast. Use static_cast<int64_t>(...) instead [readability/casting] [4]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3101| Using C-style cast. Use static_cast<int64_t>(...) instead [readability/casting] [4]
onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc|104| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc|199| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/providers/webnn/builders/impl/dropout_op_builder.cc|56| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/providers/webnn/builders/impl/transpose_op_builder.cc|43| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/session/ep_factory_internal.cc|18| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/session/ep_factory_internal.cc|54| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/session/ep_factory_internal.h|93| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/session/ep_factory_internal.h|86| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/session/ep_library_internal.cc|97| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/session/ep_library_internal.cc|166| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/session/ep_library_internal.cc|175| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/session/ep_library_internal.cc|259| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/session/ep_library_internal.cc|259| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/session/ep_library_provider_bridge.cc|113| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/session/onnxruntime_c_api.cc|3280| Add #include for unique_ptr<> [build/include_what_you_use] [4]

Filtered Findings (0)

Annotations

Check notice on line 200 in include/onnxruntime/core/session/environment.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/session/environment.h#L200

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
include/onnxruntime/core/session/environment.h:200:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check notice on line 14 in onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc#L14

 Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
Raw output
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc:14:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]

Check notice on line 80 in onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc#L80

 Add #include <string> for string  [build/include_what_you_use] [4]
Raw output
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc:80:  Add #include <string> for string  [build/include_what_you_use] [4]

Check notice on line 226 in onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc#L226

 Add #include <vector> for vector<>  [build/include_what_you_use] [4]
Raw output
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.cc:226:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]

Check notice on line 13 in onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.h#L13

 Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
Raw output
onnxruntime/contrib_ops/webgpu/quantization/gather_block_quantized.h:13:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]

Check notice on line 21 in onnxruntime/core/framework/allocator.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/framework/allocator.cc#L21

 Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
Raw output
onnxruntime/core/framework/allocator.cc:21:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]

Check notice on line 10 in onnxruntime/core/framework/plugin_ep_stream.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/framework/plugin_ep_stream.cc#L10

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
onnxruntime/core/framework/plugin_ep_stream.cc:10:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check notice on line 15 in onnxruntime/core/framework/plugin_ep_stream.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/framework/plugin_ep_stream.cc#L15

 Add #include <memory> for make_unique<>  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/framework/plugin_ep_stream.cc:15:  Add #include <memory> for make_unique<>  [build/include_what_you_use] [4]

Check notice on line 103 in onnxruntime/core/framework/plugin_ep_stream.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/framework/plugin_ep_stream.h#L103

 Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/framework/plugin_ep_stream.h:103:  Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]

Check notice on line 8 in onnxruntime/core/optimizer/transpose_optimization/ort_transpose_optimization.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/optimizer/transpose_optimization/ort_transpose_optimization.cc#L8

 Found C system header after C++ system header. Should be: ort_transpose_optimization.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
onnxruntime/core/optimizer/transpose_optimization/ort_transpose_optimization.cc:8:  Found C system header after C++ system header. Should be: ort_transpose_optimization.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 237 in onnxruntime/core/providers/cann/cann_utils.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cann/cann_utils.cc#L237

 Add #include <string> for string  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/cann/cann_utils.cc:237:  Add #include <string> for string  [build/include_what_you_use] [4]

Check notice on line 12 in onnxruntime/core/providers/cann/cann_utils.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cann/cann_utils.h#L12

 <filesystem> is an unapproved C++17 header.  [build/c++17] [5]
Raw output
onnxruntime/core/providers/cann/cann_utils.h:12:  <filesystem> is an unapproved C++17 header.  [build/c++17] [5]

Check notice on line 11 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L11

 Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:11:  Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 12 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L12

 Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:12:  Found C++ system header after other header. Should be: cuda_provider_factory.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 396 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L396

 Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:396:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]

Check notice on line 528 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L528

 Using C-style cast.  Use reinterpret_cast<OrtDataTransferImpl*>(...) instead  [readability/casting] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:528:  Using C-style cast.  Use reinterpret_cast<OrtDataTransferImpl*>(...) instead  [readability/casting] [4]

Check notice on line 669 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L669

 Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:669:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]

Check notice on line 872 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L872

 Add #include <utility> for move  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:872:  Add #include <utility> for move  [build/include_what_you_use] [4]

Check notice on line 920 in onnxruntime/core/providers/cuda/cuda_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/cuda/cuda_provider_factory.cc#L920

 Add #include <vector> for vector<>  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/cuda/cuda_provider_factory.cc:920:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]

Check notice on line 232 in onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc#L232

 Add #include <string> for string  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc:232:  Add #include <string> for string  [build/include_what_you_use] [4]

Check notice on line 248 in onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc#L248

 Add #include <memory> for make_unique<>  [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc:248:  Add #include <memory> for make_unique<>  [build/include_what_you_use] [4]

Check notice on line 608 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L608

 If an else has a brace on one side, it should have it on both  [readability/braces] [5]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:608:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]

Check notice on line 2344 in onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2344

 Using C-style cast.  Use static_cast<int64_t>(...) instead  [readability/casting] [4]
Raw output
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc:2344:  Using C-style cast.  Use static_cast<int64_t>(...) instead  [readability/casting] [4]

Check notice on line 3101 in onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L3101

 Using C-style cast.  Use static_cast<int64_t>(...) instead  [readability/casting] [4]
Raw output
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc:3101:  Using C-style cast.  Use static_cast<int64_t>(...) instead  [readability/casting] [4]

Check notice on line 104 in onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc#L104

 Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/vitisai/vitisai_provider_factory.cc:104:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [4]