Sync ORT main 16 07 25#744
reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (12)
include/onnxruntime/core/providers/utils/ort_graph_to_proto.h|718| #endif line should be "#endif // INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_UTILS_ORT_GRAPH_TO_PROTO_H_" [build/header_guard] [5]
include/onnxruntime/core/providers/utils/ort_graph_to_proto.h|545| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/providers/cpu/quantization/quantize_linear.cc|309| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/providers/qnn/qnn_execution_provider.cc|1568| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider_custom_ops.cc|97| Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
onnxruntime/core/providers/webgpu/tensor/scatter_nd.cc|163| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/providers/webnn/builders/impl/einsum_op_builder.cc|725| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/providers/webnn/builders/impl/matMulNBits_op_builder.cc|192| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc|338| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/session/ep_factory_internal.cc|17| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/session/onnxruntime_c_api.cc|2738| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/session/onnxruntime_c_api.cc|2739| Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
Filtered Findings (0)
Annotations
Check notice on line 718 in include/onnxruntime/core/providers/utils/ort_graph_to_proto.h
github-actions / cpplint
[cpplint] include/onnxruntime/core/providers/utils/ort_graph_to_proto.h#L718
#endif line should be "#endif // INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_UTILS_ORT_GRAPH_TO_PROTO_H_" [build/header_guard] [5]
Raw output
include/onnxruntime/core/providers/utils/ort_graph_to_proto.h:718: #endif line should be "#endif // INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_UTILS_ORT_GRAPH_TO_PROTO_H_" [build/header_guard] [5]
Check notice on line 545 in include/onnxruntime/core/providers/utils/ort_graph_to_proto.h
github-actions / cpplint
[cpplint] include/onnxruntime/core/providers/utils/ort_graph_to_proto.h#L545
Add #include <utility> for move [build/include_what_you_use] [4]
Raw output
include/onnxruntime/core/providers/utils/ort_graph_to_proto.h:545: Add #include <utility> for move [build/include_what_you_use] [4]
Check notice on line 309 in onnxruntime/core/providers/cpu/quantization/quantize_linear.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/cpu/quantization/quantize_linear.cc#L309
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw output
onnxruntime/core/providers/cpu/quantization/quantize_linear.cc:309: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Check notice on line 1568 in onnxruntime/core/providers/qnn/qnn_execution_provider.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/qnn/qnn_execution_provider.cc#L1568
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/qnn/qnn_execution_provider.cc:1568: Add #include <string> for string [build/include_what_you_use] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider_custom_ops.cc#L97
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
Raw output
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider_custom_ops.cc:97: Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
Check notice on line 163 in onnxruntime/core/providers/webgpu/tensor/scatter_nd.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/webgpu/tensor/scatter_nd.cc#L163
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw output
onnxruntime/core/providers/webgpu/tensor/scatter_nd.cc:163: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Check notice on line 725 in onnxruntime/core/providers/webnn/builders/impl/einsum_op_builder.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/webnn/builders/impl/einsum_op_builder.cc#L725
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw output
onnxruntime/core/providers/webnn/builders/impl/einsum_op_builder.cc:725: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Check notice on line 192 in onnxruntime/core/providers/webnn/builders/impl/matMulNBits_op_builder.cc
github-actions / cpplint
[cpplint] onnxruntime/core/providers/webnn/builders/impl/matMulNBits_op_builder.cc#L192
Add #include <vector> for vector<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/webnn/builders/impl/matMulNBits_op_builder.cc:192: Add #include <vector> for vector<> [build/include_what_you_use] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc#L338
Add #include <vector> for vector<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc:338: Add #include <vector> for vector<> [build/include_what_you_use] [4]
Check notice on line 17 in onnxruntime/core/session/ep_factory_internal.cc
github-actions / cpplint
[cpplint] onnxruntime/core/session/ep_factory_internal.cc#L17
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/session/ep_factory_internal.cc:17: Add #include <string> for string [build/include_what_you_use] [4]
Check notice on line 2738 in onnxruntime/core/session/onnxruntime_c_api.cc
github-actions / cpplint
[cpplint] onnxruntime/core/session/onnxruntime_c_api.cc#L2738
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/session/onnxruntime_c_api.cc:2738: Add #include <string> for string [build/include_what_you_use] [4]
Check notice on line 2739 in onnxruntime/core/session/onnxruntime_c_api.cc
github-actions / cpplint
[cpplint] onnxruntime/core/session/onnxruntime_c_api.cc#L2739
Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/session/onnxruntime_c_api.cc:2739: Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]