Add QDQ scale propagation pass#713
reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (17)
onnxruntime/core/providers/openvino/ov_protobuf_utils.cpp|4| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|4| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|7| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|8| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|9| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|10| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|11| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|12| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|12| is an unapproved C++17 header. [build/c++17] [5]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|13| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|14| Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|54| Constructors callable with one argument should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|301| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|629| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|798| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp|932| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.h|16| Add #include for unique_ptr<> [build/include_what_you_use] [4]
Filtered Findings (0)
Annotations
Check notice on line 4 in onnxruntime/core/providers/openvino/ov_protobuf_utils.cpp
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/ov_protobuf_utils.cpp#L4
Include the directory when naming header files [build/include_subdir] [4]
Raw output
onnxruntime/core/providers/openvino/ov_protobuf_utils.cpp:4: Include the directory when naming header files [build/include_subdir] [4]
Check notice on line 4 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L4
Include the directory when naming header files [build/include_subdir] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:4: Include the directory when naming header files [build/include_subdir] [4]
Check notice on line 7 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L7
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:7: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Check notice on line 8 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L8
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:8: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Check notice on line 9 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L9
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:9: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L10
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:10: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L11
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:11: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L12
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:12: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L12
<filesystem> is an unapproved C++17 header. [build/c++17] [5]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:12: <filesystem> is an unapproved C++17 header. [build/c++17] [5]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L13
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:13: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L14
Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:14: Found C++ system header after other header. Should be: qdq_scales_fix.h, c system, c++ system, other. [build/include_order] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L54
Constructors callable with one argument should be marked explicit. [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:54: Constructors callable with one argument should be marked explicit. [runtime/explicit] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L301
Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:301: Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L629
Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:629: Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L798
Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:798: Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp#L932
Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.cpp:932: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Check notice on line 16 in onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.h
github-actions / cpplint
[cpplint] onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.h#L16
Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Raw output
onnxruntime/core/providers/openvino/qdq_transformations/qdq_scales_fix.h:16: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]