Merged
Conversation
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yi <yi>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a naive scaling mechanism controlled by an environment variable.
- Adds the INC_FORCE_NAIVE_SCALING flag in the environment utilities.
- Bypasses additional scaling logic in the scale method factory and FP8 utility functions when the flag is enabled.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| neural_compressor/torch/utils/environ.py | Introduces a new environment variable flag to enforce naive scaling. |
| neural_compressor/torch/algorithms/fp8_quant/_core/scale_methods/scale_method_factory.py | Adds a conditional branch to bypass additional scaling configuration when naive scaling is enabled, including a warning log. |
| neural_compressor/torch/algorithms/fp8_quant/_core/fp_utils.py | Forces the backoff value to 1.0 and logs a warning when naive scaling is enabled during FP8 scale calculation. |
neural_compressor/torch/algorithms/fp8_quant/_core/scale_methods/scale_method_factory.py
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
czhu15
pushed a commit
to HabanaAI/vllm-fork
that referenced
this pull request
May 16, 2025
Depends on intel/neural-compressor#2211. Naive scaling: `backoff=1`, no `scaling_round_method` Full pile: use all samples(> 1024) in pile for calibration, https://huggingface.co/Yi30/inc-woq-2282samples-514-g2 Signed-off-by: yiliu30 <yi4.liu@intel.com>
Yanli2190
added a commit
to Yanli2190/neural-compressor
that referenced
this pull request
Jan 13, 2026
* add naive scaling Signed-off-by: yiliu30 <yi4.liu@intel.com> Signed-off-by: Zhang, Yanli L <yanli.l.zhang@intel.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed