support update config after initialization #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin He <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances config updating by propagating changes to the global configuration and related components.
- Introduces an _is_initialized flag to control post-initialization logic.
- Overrides setattr in BaseConfig to trigger _post_init when a parameter in params_list is updated.
XuehaoSun
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Xin He <[email protected]> Co-authored-by: Xin He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Enhancement of config
Description
When updating config attribution, we need to propagate the update to global config and others