refactor folder of torch 3x API and refine RTN #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xin3he
force-pushed
the
xinhe/patch-2
branch
2 times, most recently
from
d90a953 to
335295f
Compare
xin3he
force-pushed
the
xinhe/patch-2
branch
2 times, most recently
from
3c7ea1b to
ce10e9c
Compare
Kaihui-intel
requested changes
Jan 25, 2024
Signed-off-by: xin3he <[email protected]>
xin3he
changed the title
Signed-off-by: xin3he <[email protected]>
yiliu30
approved these changes
Jan 25, 2024
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Kaihui-intel
approved these changes
Jan 26, 2024
yiliu30
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
The overall folder structure follows the layout outlined in #1445 (comment). I've added comments specific to Torch.
I assume that the EXT test and UT coverage guarantee correctness and did not delve into the implementation details.
yiliu30
reviewed
Jan 26, 2024
Signed-off-by: xin3he <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: xin3he <[email protected]>
chensuyue
force-pushed
the
xinhe/patch-2
branch
from
18a1a3a to
68c2c0d
Compare
Signed-off-by: chensuyue <[email protected]>
chensuyue
force-pushed
the
xinhe/patch-2
branch
from
68c2c0d to
4eb89bf
Compare
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
enhancement
Description
refactor folder of torch 3x API and add precision check UTs for RTN.
Expected Behavior & Potential Risk
UT pass