Skip to content

[SYCL] Rename detail::dim_loop -> detail::loop and make it constexpr-friendly #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 1 commit into from
Apr 19, 2023
Merged

[SYCL] Rename detail::dim_loop -> detail::loop and make it constexpr-friendly #9108

steffenlarsen merged 1 commit into from
Apr 19, 2023

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Apr 18, 2023

Can be used like this now:

  loop<2>([](auto i) {
    if constexpr (i == 0)
      std::cout << "constexpr 0\n";
    std::cout << i << std::endl;
  });

@aelovikov-intel
[SYCL] Rename detail::dim_loop -> detail::loop and make it constexpr-…
85748f6 
…friendly

Can be used like this now:

```
  loop<2>([](auto i) {
    if constexpr (i == 0)
      std::cout << "constexpr 0\n";
    std::cout << i << std::endl;
  });
```
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 18, 2023 17:53
@aelovikov-intel aelovikov-intel mentioned this pull request Apr 18, 2023
Closed
@aelovikov-intel aelovikov-intel temporarily deployed to aws April 18, 2023 19:38 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws April 19, 2023 04:30 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Apr 19, 2023

I think runner problem is infrastructural and isn't related to this change.
@intel/llvm-gatekeepers , if you'd agree, this is ready.

@steffenlarsen steffenlarsen merged commit 6aa3ea7 into intel:sycl Apr 19, 2023
@aelovikov-intel aelovikov-intel deleted the dim-loop-refactor branch May 1, 2023 16:13
@jle-quel jle-quel mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aelovikov-intel @sergey-semenov @steffenlarsen