Skip to content

[CI] Resolve artifacts name collision in Nightly #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 1 commit into from
Apr 3, 2023
Merged

[CI] Resolve artifacts name collision in Nightly #8926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/sycl_nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
secrets: inherit
with:
build_cache_root: "/__w/"
build_artifact_suffix: default
build_artifact_suffix: default-2204
Copy link
Contributor

@aelovikov-intel aelovikov-intel Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference to

Suggested change
build_artifact_suffix: default-2204
build_artifact_suffix: ubuntu2204

to align with the step's name, but that is subjective.

Copy link
Contributor Author

@bader bader Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"default" here means build configuration. In addition to "default" we have "no-assert" build and "self-build".

Copy link
Contributor Author

@bader bader Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align with the step's name, but that is subjective.

We are going to drop ubuntu2004 steps in #7671.

build_configure_extra_args: ''
build_image: "ghcr.io/intel/llvm/ubuntu2204_build:latest"

Expand All @@ -57,7 +57,7 @@ jobs:
with:
build_cache_root: "/__w/"
build_cache_suffix: opaque_pointers
build_artifact_suffix: opaque_pointers
build_artifact_suffix: opaque_pointers-2204
build_configure_extra_args: "--hip --cuda --enable-esimd-emulator --cmake-opt=-DSPIRV_ENABLE_OPAQUE_POINTERS=TRUE"
build_image: "ghcr.io/intel/llvm/ubuntu2204_build:latest"

Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
with:
name: sycl_linux_default
name: sycl_linux_default-2204
path: devops/
- name: Build and Push Container (with drivers)
uses: ./devops/actions/build_container
Expand Down