Skip to content

[SYCL] Don't return empty platforms #7923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 3 commits into from
Jan 12, 2023
Merged

[SYCL] Don't return empty platforms #7923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
644ba6c
empty platforms shouldn't be gathered
cperkinsintel Jan 5, 2023
1b470ee
i forgot to clang-format, and now I must pay
cperkinsintel Jan 5, 2023
e52d338
reviewer feedback. add comment with spec citation
cperkinsintel Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sycl/source/detail/platform_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,11 @@ std::vector<platform> platform_impl::get_platforms() {
// insert PiPlatform into the Plugin
Plugin.getPlatformId(PiPlatform);
}
// The users of (deprecated) SYCL_DEVICE_ALLOWLIST expect that
// platforms with no devices will not be reported.
if (!SYCLConfig<SYCL_DEVICE_ALLOWLIST>::get() ||
!Platform.get_devices(info::device_type::all).empty()) {

// The SYCL spec says that a platform has one or more devices. ( SYCL
// 2020 4.6.2 ) If we have an empty platform, we don't report it back
// from platform::get_platforms().
if (!Platform.get_devices(info::device_type::all).empty()) {
Platforms.push_back(Platform);
}
}
Expand Down