[SYCL] Add buffer container constructor and CTAD #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandschulz
force-pushed
the
buffer_container_ctad
branch
from
ddf4392 to
b50f3d5
Compare
rolandschulz
commented
Nov 5, 2019
rolandschulz
commented
Nov 5, 2019
rolandschulz
force-pushed
the
buffer_container_ctad
branch
2 times, most recently
from
1197022 to
01d33e0
Compare
keryell
previously approved these changes
Nov 6, 2019
bader
previously approved these changes
Nov 10, 2019
bader
changed the title
romanovvlad
reviewed
Nov 11, 2019
|
@rolandschulz, there are unresolved comments, but I'm not sure if we expect any changes in the code. |
Prototype of a proposal to add a buffer constructor which takes a contiguous buffer as an argument to simplify usage. Signed-off-by: Roland Schulz <[email protected]>
Signed-off-by: Roland Schulz <[email protected]>
Signed-off-by: Roland Schulz <[email protected]>
rolandschulz
force-pushed
the
buffer_container_ctad
branch
from
7534dad to
bff7061
Compare
Sorry forgot about the one comment. Done. Also rebased. |
romanovvlad
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype of a proposal to add a buffer constructor which takes a contiguous buffer as an argument to simplify usage and add buffer deduction guides for both iterator and container.