Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add Unified Runtime Plugin #7521

Merged
merged 29 commits into from
Dec 16, 2022
Merged

[SYCL] Add Unified Runtime Plugin #7521

merged 29 commits into from
Dec 16, 2022

Conversation

smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Nov 23, 2022

Add new pi_unified_plugin that implements only piPlatformsGet (via Unified Runtime zerPlatformGet)
The next step is to add a new backend to SYCL and actually start calling to pi_unified_plugin

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel changed the title update build system to add pi_unified_runtime [SYCL] Add Unified Runtime Plugin Dec 2, 2022
@smaslov-intel smaslov-intel marked this pull request as ready for review December 2, 2022 04:35
@smaslov-intel smaslov-intel requested review from a team as code owners December 2, 2022 04:35
Comment on lines +55 to +72
# These are short-term shared with Unified Runtime
# The two plugins define a few things differrently so must
# be built separately. This difference is spelled in
# their "ur_bindings.hpp" files.
#
"ur_bindings.hpp"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only tricky change I would say. Basically some functions in "Unified Runtime", those that allocate new handles, act as a factory. The Level-Zero PI Plugin handle inherits from the Unified Runtime extending it with more functionality (still gradually all moving to Unified Runtime). Since this is a short-living solution think these "bindings" appeared to be good enough.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a couple missing newlines at the end of some files, I am okay with this.

@smaslov-intel
Copy link
Contributor Author

@pvchupin , @againull : please review/merge

@againull
Copy link
Contributor

againull commented Dec 7, 2022

As we discussed offline, the only concern is that we removed the ability to build plugin using provided headers and loader. Other changes look good to me.

@smaslov-intel
Copy link
Contributor Author

As we discussed offline, the only concern is that we removed the ability to build plugin using provided headers and loader.

I retained the ability to use custom provided L0 and UR: d5c468e

Hand verified with:
$ python3 ~/sycl/pub/buildbot/configure.py -t Debug --l0-headers=/path/to/include/level_zero --l0-loader=/path/to/libze_loader.so

@smaslov-intel
Copy link
Contributor Author

The testing is gated by #7730

smaslov-intel and others added 22 commits December 15, 2022 21:05
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
@pvchupin
Copy link
Contributor

@smaslov-intel, there are post-commit issues on windows and clang build: https://github.com/intel/llvm/actions/runs/3711245053

pvchupin pushed a commit to pvchupin/llvm that referenced this pull request Dec 18, 2022
@smaslov-intel
Copy link
Contributor Author

@smaslov-intel, there are post-commit issues on windows and clang build: https://github.com/intel/llvm/actions/runs/3711245053

#7827

againull pushed a commit that referenced this pull request Dec 19, 2022
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
Add new pi_unified_plugin that implements only piPlatformsGet (via Unified Runtime zerPlatformGet)
The next step is to add a new backend to SYCL and actually start calling to pi_unified_plugin

Signed-off-by: Sergey V Maslov <[email protected]>
Co-authored-by: Pavel V Chupin <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants