-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add Unified Runtime Plugin #7521
Conversation
# These are short-term shared with Unified Runtime | ||
# The two plugins define a few things differrently so must | ||
# be built separately. This difference is spelled in | ||
# their "ur_bindings.hpp" files. | ||
# | ||
"ur_bindings.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only tricky change I would say. Basically some functions in "Unified Runtime", those that allocate new handles, act as a factory. The Level-Zero PI Plugin handle inherits from the Unified Runtime extending it with more functionality (still gradually all moving to Unified Runtime). Since this is a short-living solution think these "bindings" appeared to be good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a couple missing newlines at the end of some files, I am okay with this.
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero.cpp
Outdated
Show resolved
Hide resolved
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero.hpp
Outdated
Show resolved
Hide resolved
As we discussed offline, the only concern is that we removed the ability to build plugin using provided headers and loader. Other changes look good to me. |
I retained the ability to use custom provided L0 and UR: d5c468e Hand verified with: |
The testing is gated by #7730 |
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
…ero.cpp Co-authored-by: Steffen Larsen <[email protected]>
…ero.hpp Co-authored-by: Steffen Larsen <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel, there are post-commit issues on windows and clang build: https://github.com/intel/llvm/actions/runs/3711245053 |
|
Add new pi_unified_plugin that implements only piPlatformsGet (via Unified Runtime zerPlatformGet) The next step is to add a new backend to SYCL and actually start calling to pi_unified_plugin Signed-off-by: Sergey V Maslov <[email protected]> Co-authored-by: Pavel V Chupin <[email protected]> Co-authored-by: Steffen Larsen <[email protected]>
Add new pi_unified_plugin that implements only piPlatformsGet (via Unified Runtime zerPlatformGet)
The next step is to add a new backend to SYCL and actually start calling to pi_unified_plugin
Signed-off-by: Sergey V Maslov [email protected]