[SPIRV] Include <cctype> to fix error on Windows due to std::isspace … #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usage Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Contributor
Author
|
Guys, please take a look at this fix. It is a 1 line fix that unblocks the build on MSVC-2017. |
kbobrovs
approved these changes
Oct 21, 2019
Contributor
|
@v-klochkov, is this patch committed to https://github.com/KhronosGroup/SPIRV-LLVM-Translator? |
Contributor
Author
|
@bader, thank you for the note. I have just created KhronosGroup/SPIRV-LLVM-Translator#364 there. |
vladimirlaz
pushed a commit
that referenced
this pull request
Sep 29, 2020
Removed executable bit from test files Moved some tests into separate directories to group them by the extension they supposed to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usage
Signed-off-by: Vyacheslav N Klochkov [email protected]