-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL] Queue shortcut functions with placeholder accessors #7266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romanovvlad
merged 12 commits into
intel:sycl
from
andylshort:alamzeds/queue-shortcuts-sycl2020
Nov 14, 2022
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bacab9d
Initial version of queue shortcut functions
30cc735
Removed clang-format-related spaces in variadic args
987143c
Preliminary tests for queue shortcuts
3caf859
Replaced queue placeholder unit test with e2e test
dbe881a
Added missing newline to end of test file
b814935
Added relevant documentation to each new function
90b449f
Moved end-to-end test to llvm-test-suite
943d754
Added code location information to shortcut functions
0b4f39c
Unit test to verify correct PI functions called
43aac87
Fixed copyright header message
2c4297d
Queue now uses context bound to platform
4b5b378
Removed unused context object in TestContext class
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure the API works with placeholder accessors only, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it should be as this is a function on queue, so at this level it should only be possible to have placeholder and host accessors, the latter being moved to
host_accessor. We could have a check to make sure it is not a host accessor in the meantime.