Skip to content

[ESIMD] Follow-up fix for ESIMDOptimizeVecArgCallConv memory corruption. #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 3 commits into from
Sep 29, 2022
Merged

[ESIMD] Follow-up fix for ESIMDOptimizeVecArgCallConv memory corruption. #6908

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62d3013
[ESIMD] Follow-up fix for ESIMDOptimizeVecArgCallConv memory corruption.
kbobrovs Sep 28, 2022
3663f51
Merge remote-tracking branch 'intel/sycl' into esimd_call_conv_opt_fix1
kbobrovs Sep 29, 2022
71e4767
clang-format
kbobrovs Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion llvm/lib/SYCLLowerIR/ESIMD/ESIMDOptimizeVecArgCallConv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,13 @@ static bool processFunction(Function *F) {
// Optimize the function.
Function *NewF = optimizeFunction(F, OptimizeableParams, NewParamTs);

// Copy users to a separate container, to enable safe eraseFromParent
// within optimizeCall.
SmallVector<User*> FUsers;
Comment thread
kbobrovs marked this conversation as resolved.
Outdated
std::copy(F->users().begin(), F->users().end(), std::back_inserter(FUsers));

// Optimize calls to the function.
for (auto *U : F->users()) {
for (auto *U : FUsers) {
auto *Call = cast<CallInst>(U);
assert(Call->getCalledFunction() == F);
optimizeCall(Call, NewF, OptimizeableParams);
Expand Down