[SYCL] Add MAJOR_VERSION to the name of the sycl library on Win #6745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/verify with intel/llvm-test-suite#1237 |
mdtoguchi
reviewed
Sep 8, 2022
Contributor
mdtoguchi
left a comment
mdtoguchi
left a comment
There was a problem hiding this comment.
Overall, the changes are pretty straightforward and prevent any unexpected usage of an old library at runtime. Just feels... odd.
mdtoguchi
previously approved these changes
Sep 9, 2022
Contributor
Author
Known issue - being addressed at intel/llvm-test-suite#1138 |
aelovikov-intel
dismissed stale reviews from mdtoguchi and romanovvlad
via
695bd4f
Contributor
Author
|
/verify with intel/llvm-test-suite#1237 |
Contributor
Author
|
/verify with intel/llvm-test-suite#1237 |
mdtoguchi
approved these changes
Sep 14, 2022
romanovvlad
approved these changes
Sep 14, 2022
Contributor
Author
|
The failure in ESMID Emu task looks unrelated and I believe I saw another notification (for another PR) saying it's being worked on already. Update: being fixed in intel/llvm-test-suite#1264 . @intel/llvm-gatekeepers , please merge this together with intel/llvm-test-suite#1237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.