[SYCL][NFC] Refactor [[intel::reqd_sub_group_size()]] attribute tests #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates tests for [[intel::reqd_sub_group_size()]] attribute: 1. separates AST and diagnostics to make it easier to read/follow-up. 2. removes duplicate test cases. 3. adds missing tests. 4. no compiler changes. Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
elizabethandrews
approved these changes
Jun 6, 2022
Contributor
Author
|
Thank you for reviews. @intel/llvm-gatekeepers, this PR is ready to be merged. Thank you |
pcolberg
reviewed
Jun 6, 2022
Contributor
|
Reverted after a chat with @smanna12 |
smanna12
added a commit
to smanna12/llvm
that referenced
this pull request
Jun 8, 2022
…intel#6243) This patch updates tests for [[intel::reqd_sub_group_size()]] attribute: * separates AST and diagnostics to make it easier to read/follow-up. * removes duplicate test cases. * adds missing tests. * no compiler changes. Signed-off-by: Soumi Manna [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates tests for [[intel::reqd_sub_group_size()]] attribute:
Signed-off-by: Soumi Manna [email protected]