Annotated refactorization after ABI constraint relaxed#5929
Closed
sherry-yuan wants to merge 1 commit intointel:syclfrom
Closed
Annotated refactorization after ABI constraint relaxed#5929sherry-yuan wants to merge 1 commit intointel:syclfrom
sherry-yuan wants to merge 1 commit intointel:syclfrom
Conversation
Some unnecessary change was needed in order to maintain ABI compatibility. This change annotate these changes with TODOs such that it can be refactored after ABI constraint is relaxed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some unnecessary change was needed in order to maintain ABI compatibility.
This change annotate these changes with TODOs such that it can be refactored after
ABI constraint is relaxed.
Will add more comments after #5766 is in.