Skip to content

Comments

[ESIMD] Fix minor bug in ballot SFINAE filtering.#5913

Merged
kbobrovs merged 1 commit intointel:syclfrom
kbobrovs:fix_esimd_math
Mar 30, 2022
Merged

[ESIMD] Fix minor bug in ballot SFINAE filtering.#5913
kbobrovs merged 1 commit intointel:syclfrom
kbobrovs:fix_esimd_math

Conversation

@kbobrovs
Copy link
Contributor

It lead to the following warning below and allowing unintended types:
...sycl/ext/intel/esimd/math.hpp:685:22: warning: address of function 'detail::is_type<unsigned short, cl::sycl::ext::intel::esimd::ushort, cl::sycl::ext::intel::esimd::uint>' will always
evaluate to 'true' [-Wpointer-bool-conversion]
std::enable_if_t<detail::is_type<T, ushort, uint> && (N > 0 && N <= 32),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~

Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com

It lead to the following warning below and allowing unintended types:
...sycl/ext/intel/esimd/math.hpp:685:22: warning: address of function 'detail::is_type<unsigned short, cl::sycl::ext::intel::esimd::ushort, cl::sycl::ext::intel::esimd::uint>' will always
      evaluate to 'true' [-Wpointer-bool-conversion]
    std::enable_if_t<detail::is_type<T, ushort, uint> && (N > 0 && N <= 32),
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~

Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
@kbobrovs kbobrovs requested a review from sndmitriev March 29, 2022 05:35
@kbobrovs kbobrovs requested a review from a team as a code owner March 29, 2022 05:35
Copy link
Contributor

@sndmitriev sndmitriev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@kbobrovs
Copy link
Contributor Author

All test failures are unrelated

$ "FileCheck" "W:\jenkins-dir\workspace\SYCL_CI\intel\Win\Test_Suite\llvm-test-suite\SYCL\Regression\pi_release.cpp"
# command stderr:
Could not create process (q:\lref1\ref\lit\tools\windows\filecheck.exe) due to [WinError 999] Error performing inpage operation
error: command failed with exit status: 127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants