[SYCL] Emit integration header even if no kernels provided#5899
Merged
bader merged 4 commits intointel:syclfrom Mar 30, 2022
Merged
[SYCL] Emit integration header even if no kernels provided#5899bader merged 4 commits intointel:syclfrom
bader merged 4 commits intointel:syclfrom
Conversation
Since device_global variables can be declared in one file and used in another, it is possible to receive an input with device_global and no kernels. Make sure integration header and footer are emitted in this case.
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
LGTM, just a minor nit.
Co-authored-by: premanandrao <premanand.m.rao@intel.com>
smanna12
reviewed
Mar 28, 2022
smanna12
reviewed
Mar 28, 2022
…llvm into int-header-no-kernels
premanandrao
approved these changes
Mar 29, 2022
elizabethandrews
approved these changes
Mar 29, 2022
Contributor
Author
|
Thanks for reviews everyone! |
Contributor
Author
|
@intel/llvm-gatekeepers , I believe this one is ready for merge. The following XPASS on GPU: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since device_global variables can be declared in one file and used in
another, it is possible to receive an input with device_global and no
kernels. Make sure that integration header and footer are emitted in this
case.