-
Notifications
You must be signed in to change notification settings - Fork 843
[SYCL] Deprecate sycl::atomics in SYCL 2020 mode #5440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bader
merged 26 commits into
intel:sycl
from
IgorKharchikov:IgorKharchikov-atomic_depr-1
Feb 3, 2022
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
225c6c0
Updated image_accessor constructor
IgorKharchikov 667ce93
Added test for image_accessor const ref fix
IgorKharchikov 0645ee6
Update const_ref_image_accessor.cpp
IgorKharchikov a6eefc8
Update const_ref_image_accessor.cpp
IgorKharchikov f5641da
Update const_ref_image_accessor.cpp
IgorKharchikov b8f7509
[SYCL]Created regression test for ctz fix
IgorKharchikov d433b34
Merge pull request #1 from IgorKharchikov/IgorKharchikov-added_tests
IgorKharchikov 0f54611
Revert "[SYCL]Created regression test for ctz fix"
IgorKharchikov 42ef2fa
Merge pull request #2 from IgorKharchikov/revert-1-IgorKharchikov-add…
IgorKharchikov 7465d36
Update const_ref_image_accessor.cpp
IgorKharchikov 9b4be53
Update const_ref_image_accessor.cpp
IgorKharchikov bcf96d3
Merge branch 'intel:sycl' into sycl
IgorKharchikov f30e0b4
Merge branch 'intel:sycl' into sycl
IgorKharchikov 333ea45
Update const_ref_image_accessor.cpp
IgorKharchikov e650676
Update const_ref_image_accessor.cpp
IgorKharchikov 92a181c
Update sycl/test/check_device_code/const_ref_image_accessor.cpp
IgorKharchikov 96e6c67
Merge branch 'intel:sycl' into sycl
IgorKharchikov 473c784
Merge branch 'intel:sycl' into sycl
IgorKharchikov 05d3e9f
Merge branch 'intel:sycl' into sycl
IgorKharchikov a8c1492
Update atomic.hpp
IgorKharchikov b064743
Create atomic_deprecated.cpp
IgorKharchikov 2d73f27
Update sycl_2020_deprecations.cpp
IgorKharchikov 5aeef52
Delete atomic_deprecated.cpp
IgorKharchikov 74acc39
Update sycl_2020_deprecations.cpp
IgorKharchikov af9ba65
Update sycl_2020_deprecations.cpp
IgorKharchikov d0a07a6
Update sycl_2020_deprecations.cpp
IgorKharchikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // RUN: %clangxx %fsycl-host-only -fsyntax-only -Xclang -verify -Xclang -verify-ignore-unexpected=note %s | ||
|
|
||
| #include <sycl/sycl.hpp> | ||
| int main() { | ||
| cl::sycl::multi_ptr<int, cl::sycl::access::address_space::global_space> a( | ||
| nullptr); | ||
| // expected-warning@+1 {{'atomic<int, sycl::access::address_space::global_space>' is deprecated: sycl::atomic is deprecated since SYCL 2020}} | ||
| cl::sycl::atomic<int> b(a); | ||
| return 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.