[SYCL] update for run-on-host-intel#5414
Merged
pvchupin merged 1 commit intointel:syclfrom Jan 29, 2022
Merged
Conversation
…it to prevent errors on cleanup. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Comment on lines
+2143
to
+2145
| ArgsBlob[0] = (void *)CopyReqs; | ||
| ArgsBlob[1] = (void *)CopyHostKernel; | ||
| ArgsBlob[2] = (void *)CopyNDRDesc; |
Contributor
There was a problem hiding this comment.
NIT: Would it be better to wrap these into a struct passed as a single first argument?
smaslov-intel
approved these changes
Jan 29, 2022
Contributor
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
LGTM. Is it possible to cover this with a test?
Contributor
Yes, @dm-vodopyanov and @cperkinsintel working on the test. They will follow up with separate PR. |
dm-vodopyanov
added a commit
that referenced
this pull request
Feb 3, 2022
This patch adds unit test for #5414. This test creates ExecCGCommand with some known values needed in RT to restore context in host task. After that we start enqueueing and verify the correctness of these values in mocked piEnqueueNativeKernel func.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the deprecated run-on-host-intel is still being used. Need to update it to prevent errors on cleanup.
Signed-off-by: Chris Perkins chris.perkins@intel.com