[Driver][SYCL] Initial support for allowing fat static -lname processing#5413
Merged
bader merged 2 commits intointel:syclfrom Feb 3, 2022
Merged
[Driver][SYCL] Initial support for allowing fat static -lname processing#5413bader merged 2 commits intointel:syclfrom
bader merged 2 commits intointel:syclfrom
Conversation
When processing for fat static libraries, add searches for -lname type libraries passed on the command line. This also takes advantage of the -Ldir options and LIBRARY_PATH environment variable for locating the libraries. When a library is found (with a .a extension) that is what is used for unbundling and added to the device link. NOTE: This behavior does not match the recent implementation done for OpenMP offloading with fat static libraries. That implementation is directly integrated into the llvm-link call. It would be good to also follow this for consistency, but will require some refactoring to accomplish.
Contributor
Author
|
@intel/dpcpp-clang-driver-reviewers ping |
hchilama
approved these changes
Feb 2, 2022
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 5, 2022
* upstream/sycl: (3571 commits) [ESIMD] Doxygen update part III - core APIs. (intel#5472) [SYCL][DOC] Move proposed FPGA extensions (intel#5453) [SYCL] Add -fsycl-fp32-prec-sqrt flag (intel#5309) [SYCL] Emit program build logs for warning levels >= 2 (intel#5319) [SYCL] Add clang support for code_location in KernelInfo (intel#5335) [SYCL][Doc] Move FPGA extensions (intel#5470) [ESIMD] Fix public simd and simd_view APIs. (intel#5465) [SYCL] Deprecate sycl::atomics in SYCL 2020 mode (intel#5440) [SYCL] Add unit test for PR 5414 (intel#5450) [XPTI] Allow arbitrary data types in metadata (intel#4998) [SYCL][DOC] Move discard queue events to supported (intel#5452) [Driver][SYCL] Initial support for allowing fat static -lname processing (intel#5413) [SYCL] Fix dead pointer usage if leaf buffer overflows (intel#5417) [SYCL][L0] Fix memory leak in USM prefetch (intel#5461) [SYCL][Doc] Add new free function queries proposal (intel#5106) [SYCL][ESIMD] Update vc-intrinsics deps to the top of the trunk (intel#5460) [SYCL][DOC] Move old spec constant extension spec (intel#5456) [SYCL][DOC] Move deprecated extensions (intel#5458) [SYCL][DOC] Fix links to old SubGroupMask doc (intel#5459) [ESIMD] Doxygen update part II - memory APIs. (intel#5443) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing for fat static libraries, add searches for -lname type
libraries passed on the command line. This also takes advantage of
the -Ldir options and LIBRARY_PATH environment variable for locating
the libraries.
When a library is found (with a .a extension) that is what is used for
unbundling and added to the device link.
NOTE: This behavior does not match the recent implementation done for OpenMP
offloading with fat static libraries. That implementation is directly
integrated into the llvm-link call. It would be good to also follow this
for consistency, but will require some refactoring to accomplish.