Skip to content

[SYCL] Make sure [AMDGPU|NVPTX]CodeGen links in lower SYCL IR passes #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bader merged 1 commit into from
Jan 21, 2022
Merged

[SYCL] Make sure [AMDGPU|NVPTX]CodeGen links in lower SYCL IR passes #5357

bader merged 1 commit into from
Jan 21, 2022
+2 −0

Conversation

@jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Jan 21, 2022

Fixes undefined references to llvm::initializeLocalAccessorToSharedMemoryPass when creating shared libraries for AMDGPU and NVPTX codegen.

@jchlanda jchlanda requested a review from a team as a code owner January 21, 2022 13:16
@jchlanda
Copy link
Contributor Author

jchlanda commented Jan 21, 2022

cc: @bader

jchlanda referenced this pull request Jan 21, 2022
@jchlanda
[SYCL] Generalize local accessor to shared mem pass (#5149)
58508ba 
Now, that it lives in `SYCLLowerIR` it can be easily shared between AMDGCN and NVPTX backends.

This requires the same alignment fix as for Cuda, see: #5113

Fixes #5013
@jchlanda jchlanda mentioned this pull request Jan 21, 2022
Merged
@bader bader merged commit 02b7301 into intel:sycl Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader bader approved these changes

+1 more reviewer

@mlychkov mlychkov mlychkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jchlanda @bader @mlychkov