[SYCL][CUDA][HIP] Fix PI_MEM_ALLOC_DEVICE USM pointer query #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `USM/pointer_query.cpp` test from `llvm-test-suite` for HIP. For HIP the code was using the device pointer to index the device array for some reason, which is obviously incorrect, now it should be using the correct property to get the device index on the hardware. In addition for both HIP and CUDA the query was using the device index to index into the array of devices on the platform, this is incorrect since intel#4571 which moved every device in its own platform. Therefore to get the correct device we now need to use the index on the list of platforms, and then `0` on the list of devices.
npmiller
force-pushed
the
fix-pointer-query
branch
from
c38a536 to
1088ccd
Compare
steffenlarsen
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
USM/pointer_quer.cpptest fromllvm-test-suiteforHIP.
For HIP the code was using the device pointer to index the device array
for some reason, which is obviously incorrect, now it should be using
the correct property to get the device index on the hardware.
In addition for both HIP and CUDA the query was using the device index
to index into the array of devices on the platform, this is incorrect
since #4571 which moved every device in its own platform. Therefore to
get the correct device we now need to use the index on the list of
platforms, and then
0on the list of devices.