[SYCL][CUDA][MATRIX] Remove using namespace experimental from headers#5217
[SYCL][CUDA][MATRIX] Remove using namespace experimental from headers#5217bader merged 1 commit intointel:syclfrom
using namespace experimental from headers#5217Conversation
replaced with fully qualified names. Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
using namespace experimental -
Would it be easier to fix the issue for |
using namespace experimental -using namespace experimental from headers
|
@JackAKirk, please, open a PR in llvm-test-suite repository enabling Matrix/joint_matrix_tensorcore_double.cpp on CUDA. |
@yubingex007-a11y, FYI. |
Sure I will create a PR to handle that. Sorry for inconvenience. |
Here it is, intel/llvm-test-suite#680, thanks. |
|
/verify with intel/llvm-test-suite#680 |
Removed
using namespace experimental- replaced with fully qualified names.cc @vladimirlaz @bader
This PR fixes #5213. I chose to use fully qualified names instead of moving local
detailtosycl::ext::oneapi::experimental::matrix::detail, although this second option seems the most sensible to me: however I didn't movedetailat the moment for consistency with the intel matrix extension namespace use (which also coincides with the standard practice of wider dpc++ as far as I can tell).Please be aware that
using namespace experimental;is also used on line 201 of matrix-aot-amx.hpp, which could lead to similar problems in the future.Signed-off-by: jack.kirk jack.kirk@codeplay.com