[SYCL][FPGA][NFC] Update [[intel::doublepump]] and [[intel::singlepump]] attributes#5198
Merged
bader merged 5 commits intointel:syclfrom Dec 24, 2021
Merged
[SYCL][FPGA][NFC] Update [[intel::doublepump]] and [[intel::singlepump]] attributes#5198bader merged 5 commits intointel:syclfrom
bader merged 5 commits intointel:syclfrom
Conversation
…p]] atributes This patch returns the attribute itself instead of handleSimpleAttribute<> function and adds a separate handler function instead of common templated function to align with the community attributes for the two FPGA memory attributes below: 1. [[intel::doublepump] 2. [[intel::singlepump]] Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
changed the title
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
Contributor
Author
|
Test failures are unrelated to my patch: |
elizabethandrews
approved these changes
Dec 22, 2021
Contributor
Author
|
@bader, can this be merged? I have required approval and all tests have passed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch returns the attribute itself instead of handleSimpleAttribute<> function and
adds a separate handler function instead of common templated function to align with the
community attributes for the two FPGA memory attributes below:
No functionality or test changes.
Signed-off-by: Soumi Manna soumi.manna@intel.com